Skip to content

Commit

Permalink
Update Node version to 18.16.0 LTS
Browse files Browse the repository at this point in the history
Bump the `source-map` version to fix the issue: mozilla/source-map#454.

We are not updating the NPM version because there is an breaking change with the `npm config set python` which we use with `node-gyp`.
  • Loading branch information
matheusccastroo committed Jun 1, 2023
1 parent 3bb8622 commit a112ad5
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 5 deletions.
2 changes: 1 addition & 1 deletion meteor
@@ -1,6 +1,6 @@
#!/usr/bin/env bash

BUNDLE_VERSION=16.20.0.0
BUNDLE_VERSION=18.16.0.0


# OS Check. Put here because here is where we download the precompiled
Expand Down
2 changes: 1 addition & 1 deletion scripts/build-dev-bundle-common.sh
Expand Up @@ -5,7 +5,7 @@ set -u

UNAME=$(uname)
ARCH=$(uname -m)
NODE_VERSION=16.20.0
NODE_VERSION=18.16.0
MONGO_VERSION_64BIT=6.0.3
MONGO_VERSION_32BIT=3.2.22
NPM_VERSION=8.19.4
Expand Down
2 changes: 1 addition & 1 deletion scripts/dev-bundle-tool-package.js
Expand Up @@ -38,7 +38,7 @@ var packageJson = {
// https://github.com/jprichardson/node-kexec/pull/37 applied.
// TODO: We should replace this with: https://github.com/jprichardson/node-kexec/pull/38
kexec: "https://github.com/meteor/node-kexec/tarball/f29f54037c7db6ad29e1781463b182e5929215a0",
"source-map": "0.7.3",
"source-map": "0.7.4",
chalk: "4.1.1",
sqlite3: "5.0.2",
"http-proxy": "1.18.1",
Expand Down
3 changes: 3 additions & 0 deletions scripts/generate-dev-bundle.sh
Expand Up @@ -101,6 +101,9 @@ export PATH="$DIR/bin:$PATH"
cd "$DIR/lib"
# Overwrite the bundled version with the latest version of npm.
npm install "npm@$NPM_VERSION"
# Starting from npm v9.5.1 we can't set the python (and many others) config
# https://github.com/npm/cli/issues/6126 - the workaround for now is to keep
# on npm v8.19.4
npm config set python `which python3`
which node
which npm
Expand Down
2 changes: 1 addition & 1 deletion tools/cli/main.js
Expand Up @@ -603,7 +603,7 @@ makeGlobalAsyncLocalStorage().run({}, async function () {

// Check required Node version.
// This code is duplicated in tools/server/boot.js.
var MIN_NODE_VERSION = 'v16.20.0';
var MIN_NODE_VERSION = 'v18.16.0';
if (require('semver').lt(process.version, MIN_NODE_VERSION)) {
Console.error(
'Meteor requires Node ' + MIN_NODE_VERSION + ' or later.');
Expand Down
2 changes: 1 addition & 1 deletion tools/static-assets/server/boot.js
Expand Up @@ -8,7 +8,7 @@ var npmRequire = require('./npm-require.js').require;
var Profile = require('./profile').Profile;

// This code is duplicated in tools/main.js.
var MIN_NODE_VERSION = 'v16.20.0';
var MIN_NODE_VERSION = 'v18.16.0';

var hasOwn = Object.prototype.hasOwnProperty;

Expand Down

0 comments on commit a112ad5

Please sign in to comment.