Support non-ascii case folding within i modifier #90
+2,456
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
commented
Sep 30, 2023
| 'pattern': '(?i:[є-ґ])', | ||
| 'options': { modifiers: 'transform' }, | ||
| 'matches': ['\u0462', '\u0463', '\u1C87'], | ||
| 'expected': '(?:[\\u0404-\\u040F\\u0454-\\u0491\\u1C87])', |
There was a problem hiding this comment.
Here U+1C87 ᲇ should be matched because the uppercase of U+1C87 is U+0462 Ѣ, well in range of [є-ґ], while the lowercase of U+0462 Ѣ is U+0463 ѣ. So the String#toLowerCase approach in #80 will miss cases like that, which is why we have introduced iu-mappings.
JLHwung
commented
Sep 30, 2023
| 'expected': '(?:[Kk\\u212A])', | ||
| }, | ||
| { | ||
| 'pattern': '(?i:\\u2C2F)', |
There was a problem hiding this comment.
This is also an example that a legacy ES5 engine might not support all case foldings in the Basic Plane, because the U+2C2F is introduced in Unicode 14.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #79
Closes #80
Most test cases are inherited from #80 while I also commented some differences.
@stulov Thank you for your work, which is very helpful.