feat: add support for ink 4.0 (BREAKING)
#253
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: The package is now ESM
|
@maticzav Is anything holding this back from landing on I'm currently on an ESM project referencing an ESM-compatible fork, but I would prefer to reference the original package if this can get landed. |
|
😄 https://www.npmjs.com/package/@tqman/ink-table |
dskvr
reviewed
Nov 26, 2023
| "ts-node": "9.1.1", | ||
| "typescript": "4.7.4" | ||
| "typescript": "~4.9.5" | ||
| }, | ||
| "peerDependencies": { | ||
| "ink": ">=3.0.0", |
There was a problem hiding this comment.
>=4.0.0 to suppress warning (peerDependencies)
|
Is it expected that this be merged and released anytime soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR includes the commit from #252. When #252 is accepted, I can rebase to remove it from the history here.
ink4.0 is now written in ESM and I had to do some changes toink-tableto make it compatible. Unfortunately, that is a breaking change, sinceink-tablealso needs to be ESM now.I had to upgrade some dependencies, change how
jestis executed, restructuretsconfigto not have VSCode complain in test files. And while I was at it, I changed thedefaultexport to a named export (since those have given me too much trouble with bundlers in the past - specificallyesbuild).