Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move @types/react to dependency #276

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fa93hws
Copy link

@fa93hws fa93hws commented Mar 2, 2024

@types/react is used in the generated index.d.ts, it's better to put @types/react in dependencies instead of devDependencies as a consequence.

@fa93hws
Copy link
Author

fa93hws commented Mar 2, 2024

Actually, maybe "peer dependencies" would be better?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant