Use portable_atomic instead of atomic-polyfill
#251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matklad
reviewed
Dec 7, 2023
Cargo.toml
Outdated
|
|
||
| # Enables semver-exempt APIs of this crate. | ||
| # At the moment, this feature is unused. | ||
| unstable = [] | ||
|
|
||
| # Only for backwards compatibility. | ||
| atomic-polyfill = ["critical-section"] |
There was a problem hiding this comment.
Let’s keep this, it’s not a burden to support a feature alias, and this might prevent someone’s build from breaking
|
CI failure is legitimate |
|
Looking good now, thanks! Could you also bump version in Cargo.toml to 1.19.0 and add the corresponding changlelog.md entry? That way, the new version would be released as soon as the PR is merged! |
|
bors r+ Thanks! |
|
Hm, bors ping |
|
Ok, apparently the public instance of borsh.tech shut down, while the merge queue isn't available for individual repositories yet? Merging manually! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #250