[CSS Stylelint] activates some more rules (#21030)

* Expect leading & trailing whitespace in comments for better readability * disallow unknown units * disallow unmatchable selectors
matomo-org · Jul 18, 2023 · d13d4c4 · d13d4c4
1 parent d6436aa
commit d13d4c4
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 11 deletions.
diff --git a/.stylelintrc.json b/.stylelintrc.json
@@ -5,7 +5,7 @@
             "customSyntax": "postcss-less"
         }
     ],
-    "ignoreFiles": ["node_modules/**/*", "vendor/**/*", "tests/**/*", "tmp/**/*", "misc/**/*", "plugins/*/vue/dist/*", "plugins/Morpheus/stylesheets/base/bootstrap.css"],
+    "ignoreFiles": ["node_modules/**/*", "vendor/**/*", "tests/**/*", "tmp/**/*", "misc/**/*", "plugins/*/vue/dist/*", "plugins/*/tests/**/*", "plugins/Morpheus/stylesheets/base/bootstrap.css"],
     "rules": {
         "color-no-invalid-hex": true,
         "no-irregular-whitespace": true,
@@ -19,6 +19,9 @@
         ],
         "font-family-no-duplicate-names": true,
         "no-duplicate-at-import-rules": true,
-        "no-duplicate-selectors": true
+        "no-duplicate-selectors": true,
+        "comment-whitespace-inside": "always",
+        "unit-no-unknown": true,
+        "selector-anb-no-unmatchable": true
     }
 }
diff --git a/plugins/CoreHome/stylesheets/coreHome.less b/plugins/CoreHome/stylesheets/coreHome.less
@@ -59,7 +59,7 @@
     left: 200px;
 }
 
-/* Calendar*/
+/* Calendar */
 div.ui-datepicker {
     font-size: 62.5%;
 }

diff --git a/plugins/CoreHome/stylesheets/jquery.ui.autocomplete.css b/plugins/CoreHome/stylesheets/jquery.ui.autocomplete.css
@@ -1,5 +1,5 @@
 /* Autocomplete
-----------------------------------*/
+---------------------------------- */
 .ui-autocomplete {
     position: absolute;
     cursor: default;
@@ -16,7 +16,7 @@
 }
 
 /* Menu
-----------------------------------*/
+---------------------------------- */
 .ui-menu {
     list-style: none;
     padding: 6px;

diff --git a/plugins/CoreHome/vue/src/SiteSelector/SiteSelector.less b/plugins/CoreHome/vue/src/SiteSelector/SiteSelector.less
@@ -66,10 +66,6 @@
 .siteSelector.piwikSelector a.title {
   padding: 10px 15px 11px 13px;
 
-  /*.icon:not(.icon-fixed) {
-    margin-right: -11px;
-  }*/
-
   > span {
     max-width: 161px;
     overflow: hidden;

diff --git a/plugins/SegmentEditor/stylesheets/segmentation.less b/plugins/SegmentEditor/stylesheets/segmentation.less
@@ -1,4 +1,4 @@
-/* ADDITIONAL STYLES*/
+/* ADDITIONAL STYLES */
 .youMustBeLoggedIn {
     font-size: 8pt;
     font-style: italic;
@@ -380,7 +380,7 @@ html.comparisonsDisabled .segmentationContainer ul.submenu {
     background: transparent !important;
 }
 
-/* ADDITIONAL STYLES*/
+/* ADDITIONAL STYLES */
 .segment-element .segment-nav div > ul > li ul {
     margin-left: 0;
 }