Update workflow with actions/checkout@v3 to actions/checkout@v4

[mikkeschiren]

Description:

actions/checkout@v3 is deprecated, and shouldn't be used any more.
Also some minor fixes on removal of whitespaces.

A warning can be seen e.g. in the PHPCS action:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Review

• Functional review done
• Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
• Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
• Security review done
• Wording review done
• Code review done
• Tests were added if useful/possible
• Reviewed for breaking changes
• Developer changelog updated if needed
• Documentation added if needed
• Existing documentation updated if needed

[michalkleiner]

Hi @mikkeschiren and thank you for your contribution and opening the PR.
Would you happen to have a link to some information about the v3 action being deprecated?

[mikkeschiren]

Hi @mikkeschiren and thank you for your contribution and opening the PR. Would you happen to have a link to some information about the v3 action being deprecated?

Hi, sorry for not including that, you can see it in the output here as an example: https://github.com/matomo-org/matomo/actions/runs/7758937941

More information here: actions/checkout#1436

[michalkleiner]

Since all the checkout actions seem to work correctly with v4 and the failures are only the flaky tests we already know about, I'm happy with this.

I'm of two minds as to which branch it should target. For me it's a maintenance PR and could/should target 5.0.x-dev and then merged up to 5.x-dev, do you agree @sgiehl?

[sgiehl]

No big preference where to merge that to. As v3 will still work for a long time, there is no real need to have it in 5.0.x-dev, but wouldn't hurt either. As changing the base branch and rebasing the origin would be additional work I would also be fine with simply merging it as is.