ENH: Add a cycler-specific chain function. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am 30/70 on this. More open to changing the I like the analogy, but the same-named-but-special top level function floating around can get confusing. |
| @@ -549,3 +549,28 @@ def _cycler(label, itr): | |||
| itr = (v[lab] for v in itr) | |||
|
|
|||
| return Cycler._from_iter(label, itr) | |||
|
|
|||
|
|
|||
| def chain(*args): | |||
There was a problem hiding this comment.
Can we rename this to cychain?
There was a problem hiding this comment.
Sure. Would that change your 30/70 feeling on putting it in?
There was a problem hiding this comment.
I think I would merge it with this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The discussion in #1 introduced a
concatmethod. For combining more than two cyclers, it would be convenient to assign an infix operator for concatenation, but there is no obvious candidate --- as has already been discussed.What about a top-level
chainmethod, akin toitertools.chain, but one that fails immediately if keys don't match? Is this useful bloat or a fair solution for multiple concatenation, laking a suitable operator?I'm happy to see this tossed out if the answer is, "sorry, this is bloat." But I'll leave it here for discussion. If people like it, I'll add tests.