-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import Image from PIL #27940
Import Image from PIL #27940
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
c276ad3
to
cb0b5ae
Compare
Thank you for your contributions, however I am pretty negative on these changes. Reading through those issues I really don't understand why the pillow developers want to deprecate I am also 👎🏻 on using the Finally, I'm 50/50 on adding the |
I believe the user confusion mainly stems from the fact that the Image module is capitalized. Thus, by standard naming rules |
Ok, thanks for your prompt review. |
PR summary
There are places where matplotlib uses, or where the documentation refers to,
PIL.Image.open(...)
.If users were to look at this, and try and replicate it in their own code, it may not be ideal, since
doesn't work.
works, but two Pillow core developers (python-pillow/Pillow#6614 (comment) and python-pillow/Pillow#6614 (comment)) have suggested deprecating
import PIL.Image
.The ideal code
is harder for users to figure out without some external knowledge of Pillow.
So this PR attempts to avoid references to
PIL.Image
, and instead switch tofrom PIL import Image
.PR checklist