Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending trend lines (tlines) #539

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

sumprain
Copy link

Hello Daniel,

Thanks a lot for such a useful package.

I have made an enhancement in the trend line construction (using tlines kwarg in plot function).

By adding kwargs extend_start and extend_end to tlines parameter, we can extend trend line by extend_start dates from the start date and extend_end dates from end date.

Regards

@sumprain

@DanielGoldfarb
Copy link
Collaborator

@sumprain
Suman- Thank you so much for contributing to mplfinance. This enhancement looks interesting and useful. I will try to make time this week to code review and test, to be able to merge and release.

In the meantime, would you be willing to please add one or two use-case examples to the very end of the using lines tutorial. That will be very helpful.

As long as this Pull Request continues to be open, any changes you push to sumprain:master will automatically be propagated from sumprain:master into this Pull Request.

All the best. --Daniel

@sumprain
Copy link
Author

Thanks a lot @DanielGoldfarb . I will surely do the needful.

Regards.

@sumprain
Copy link
Author

While preparing examples, I detected some anomaly in slope of trend line when show-nontrading days is false. I am correcting it and will pull request it.
Thanks and Regards
@sumprain

@sumprain
Copy link
Author

Dear Daniel, I have corrected the anomalies and added use cases in using lines tutorials.

Thanks and Regards

@sumprain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants