Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Edited messages appear twice in fulltext search #3363

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

adnull
Copy link

@adnull adnull commented Apr 18, 2024

As stated in #3358 the search response contains both original and edited message.
This PR fixes it by removing of the original message from the fulltext index after indexing the edit message event.
I also made some cosmetic changes/fixes i found in the code

Signed-off-by: Alexander Dubovikov <d.lexand@gmail.com>

@adnull adnull requested a review from a team as a code owner April 18, 2024 20:45
Copy link
Contributor

@S7evinK S7evinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise!

syncapi/consumers/roomserver.go Outdated Show resolved Hide resolved
syncapi/syncapi_test.go Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants