Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Node 20 (and drop Node 16) #1701

Merged
merged 10 commits into from
Apr 27, 2023
Merged

Support Node 20 (and drop Node 16) #1701

merged 10 commits into from
Apr 27, 2023

Conversation

Half-Shot
Copy link
Contributor

See matrix-org/matrix-appservice-bridge#466.

This also moves us onto yarn, to be in line with the rest of our ecosystem.

@Half-Shot Half-Shot requested a review from a team as a code owner April 26, 2023 09:27
AndrewFerr
AndrewFerr requested changes Apr 26, 2023
View reviewed changes
Copy link
Member

@AndrewFerr AndrewFerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few minor requests.

And FWIW the lint script fails on me locally until I remove the import urlJoin line in widget/src/ProvisioningApp.tsx, so if the next CI run fails on that, it should be fixable.

Dockerfile Outdated
RUN npm run build
RUN npm prune --omit dev
RUN yarn --strict-semver --frozen-lockfile
RUN yarn build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is redundant since package.json's "prepare" step runs a build.

package.json Outdated
@@ -5,7 +5,7 @@
"main": "app.js",
"bin": "./bin/matrix-appservice-irc",
"engines": {
"node": ">=16"
"node": ">=18"
},
"scripts": {
"prepare": "npm run build",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this (and other scripts) now use their yarn equivalents?

@AndrewFerr
Copy link
Member

Hmm, apparently the E2E tests fail non-deterministically...?

AndrewFerr
AndrewFerr approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@AndrewFerr AndrewFerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as:

  • intermittent failures in the E2E CI tests are acceptable, and
  • it's fine to no longer override the matrix-bot-sdk dependency only in m-a-b's deps,

then this should be good to go.

@Half-Shot Half-Shot merged commit a6207b9 into develop Apr 27, 2023
12 checks passed
@Half-Shot Half-Shot deleted the hs/node20 branch April 27, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewFerr AndrewFerr AndrewFerr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Half-Shot @AndrewFerr