Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send references to thread root to threads, even out of order #2156

Merged
merged 6 commits into from Feb 4, 2022

Conversation

andybalaam
Copy link
Contributor

@andybalaam andybalaam commented Feb 4, 2022

Helps a bit with element-hq/element-web#20282


Here's what your changelog entry will look like:

🐛 Bug Fixes

  • Send references to thread root to threads, even out of order (#2156). Contributed by @andybalaam.

@andybalaam andybalaam requested a review from a team as a code owner February 4, 2022 14:47
@andybalaam andybalaam added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems label Feb 4, 2022
src/client.ts Outdated Show resolved Hide resolved
Co-authored-by: Germain <germains@element.io>
@andybalaam andybalaam marked this pull request as draft February 4, 2022 15:40
@andybalaam
Copy link
Contributor Author

Converted to draft since I can't actually validate that this fixes the problems any more :-(

@andybalaam
Copy link
Contributor Author

We have concluded that this makes the situation better, even though it doesn't fix everything, so undrafting.

@andybalaam andybalaam marked this pull request as ready for review February 4, 2022 15:48
@andybalaam andybalaam merged commit 2d23330 into develop Feb 4, 2022
@andybalaam andybalaam deleted the psf-687-poll-as-thread-roots branch February 4, 2022 15:50
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this pull request Feb 15, 2022
* Fix issue with rooms not getting marked as unread ([\matrix-org#2163](matrix-org#2163)). Fixes element-hq/element-web#20971.
* Don't store streams that are only used once ([\matrix-org#2157](matrix-org#2157)). Fixes element-hq/element-web#20932. Contributed by @SimonBrandner.
* Fix edge cases around RR calculations ([\matrix-org#2160](matrix-org#2160)). Fixes element-hq/element-web#20922.
* Account for encryption in `maySendMessage()` ([\matrix-org#2159](matrix-org#2159)). Contributed by @SimonBrandner.
* Send references to thread root to threads, even out of order ([\matrix-org#2156](matrix-org#2156)).
* Fix initial sync fail when event fetching unsuccessful ([\matrix-org#2150](matrix-org#2150)). Fixes element-hq/element-web#20862.
* Don't decrypt redacted messages ([\matrix-org#2143](matrix-org#2143)). Contributed by @SimonBrandner.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants