Bump matrix-sdk-crypto-wasm to 4.0.1 #4025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
added
the
T-Task
2 tasks
florianduros
approved these changes
Jan 23, 2024
richvdh
commented
Jan 23, 2024
| @@ -997,7 +1003,7 @@ describe("RustCrypto", () => { | |||
| }); | |||
|
|
|||
| it("should wait for a keys/query before returning devices", async () => { | |||
| jest.useFakeTimers(); | |||
| jest.useFakeTimers({ doNotFake: ["queueMicrotask"] }); | |||
There was a problem hiding this comment.
matrix-sdk-crypto-wasm 4.0.1 includes an update to wasm-bindgen-futures, which includes this PR, which requires that we have a working queueMicrotask.
In retrospect, bumping the transitive dependencies of matrix-sdk-crypto-wasm in a patch release was a mistake.
richvdh
commented
Jan 23, 2024
Comment on lines
+78
to
+82
| beforeAll(async () => { | ||
| // Load the WASM upfront, before any of the tests. This can take some time, and doing it here means that it gets | ||
| // a separate timeout. | ||
| await RustSdkCryptoJs.initAsync(); | ||
| }, 15000); |
There was a problem hiding this comment.
not actually part of this fix, but I think it's a useful change anyway.
t3chguy
approved these changes
Jan 23, 2024
BillCarsonFr
approved these changes
Jan 24, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is marked as an internal change (Task), so will not be included in the changelog.