Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix image not running in K8s (ROSA) #24

Merged
merged 3 commits into from
Jun 15, 2022
Merged

Fix image not running in K8s (ROSA) #24

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
833f566
Try no custom npm version
MadLittleMods Jun 15, 2022
4854161
Try different version of packaged node/npm
MadLittleMods Jun 15, 2022
9abc1e4
Put up warning post before upgrading the Node image version
MadLittleMods Jun 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 5 additions & 3 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
FROM node:16.15-buster-slim
# XXX: Before updating this, make sure the issues around `npm` silently exiting
# with error 243 issues are solved:
# - https://github.com/npm/cli/issues/4996
# - https://github.com/npm/cli/issues/4769
FROM node:16.14.2-buster-slim
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to have fixed it 🤷 . Here are the packaged versions:

$ node --version
v16.14.2
$ npm --version
8.5.0

Previously it was using:

$ node --version
v16.15.1
$ npm --version
8.11.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it could be either of these issues. Both are 8.6.0+ problems as well which lines up with the npm version available in each base image.


RUN mkdir -p /app

WORKDIR /app

RUN npm install npm@^8 --location=global
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't solve the problem but I think we can get rid of this anyway. I added it before because I saw a warning about the package-lock.json made in an earlier version and to do the one-time upgrade, etc. I didn't see the warning in the latest build anyway.


# Copy the health-check script
COPY docker-health-check.js /app/

Expand Down