fix: content shifting when the copy button appears on mobile #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same issue as #235, but on mobile and slightly different:
Screenshot.2024-05-01.at.11.13.54.mp4
The problem is that the title gets wrapped because of the share button being added and the GitHub button taking a lot of space.
An easy fix is to just hide the text and numbers on small screens, however, that will cause the GitHub button to look off next to the share button:
To fix this, I set the horizontal padding and the size of the icon to the same values as the share button:
As you can see, the shifting is gone after these changes:
Screenshot.2024-05-01.at.11.20.19.mp4