MM-27497 Patch localForage to fix logging out on old Edge

[hmhealey]

When logging out, we call a method of localForage that in turn attempts to call a browser method that's not supported on pre-Chromium versions of Edge. There's a PR submitted to fix that (localForage/localForage#971), but it's waiting to be merged and released, so I'm taking a page from the mobile app's handbook and using patch-package to temporarily apply the patch at install time since it's easier than maintaining a fork until the next version of localForage is released.

Ticket Link

https://mattermost.atlassian.net/browse/MM-27497

[hmhealey]

Lines 5373 to 5394 of the patch are the actual changes to fix the issue. The rest of the changes are because the library checks in their compiled files as well.

This link works, but you have to click to load the patch for it to scroll you to the right place.
https://github.com/mattermost/mattermost-webapp/pull/6308/files#diff-4499b04d71f37353f7e77b7b0cef7e29R5373-R5394

[enahum]

just as a mention the patch is creating a new file. not a blocker but strange

[hmhealey]

The new file was actually a problem. I copied files into node_modules wrong when preparing the patch. That should be fixed now, and the patch is much easier to read now.

[calebroseland]

Locally, I'm getting:

HTTP401: DENIED - The requested resource requires user authentication.
(Fetch)POST - http://mattermost.localdev:8065/api/v4/channels/members/me/view

Unhandled promise rejection TypeError: Invalid calling object  main.b3747573886923126066.js (239,43173)

[object Error]: {description: "Invalid calling object", message: "Invalid calling object", number: -2147418113, stack: "TypeError: Invalid calling object at Anonymous function (http://mattermost.localdev:8065/static/main.b3747573886923126066.js:199:48914) at T (http://mattermost.localdev:8065/static/main.b3747573886923126066.js:199:44009) at Anonymous function (http://mattermost.localdev:8065/static/main.b3747573886923126066.js:199:48814) at Anonymous function (http://mattermost.localdev:8065/static/main.b3747573886923126066.js:187:387048) at n (http://mattermost.localdev:8065/static/main.b3747573886923126066.js:239:42727)"}

[hmhealey]

Yeah, I'm seeing that as well. I'll take a look since clearly this fix isn't working as well as I'd hoped

[hmhealey]

I did some more testing locally, and for some reason the fix was still causing Edge to throw errors. I've instead gone with just downgrading localforage for the time being. Hopefully they'll have addressed the issue (or we'll have dropped old Edge :p) by the time we have to upgrade again.

[calebroseland]

Yep, working now ✓, LGTM

[jgilliam17]

Thank you @hmhealey
Tested, looks good to merge.

• Verified user can logout successfully on the Microsoft Edge, returns to login screen. No console errors.

[mm-cloud-bot]

Test server destroyed