adopt forked squirrel supporting from UPDATE FROM #19896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fork https://github.com/Masterminds/squirrel as https://github.com/lieut-data/squirrel with the following changes: * Masterminds/squirrel#256 supporting FROM clause to update builder (Postgres) * Extension of above to support multiple FROM in UPDATE (Postgres) * Support for multiple tables in UPDATE (MySQL) This PR then leverages those changes to simplify a query that previously had to be coded by hand and duplicate for each of MySQL and Postgres.
mm-cloud-bot
added
the
release-note-none
lieut-data
commented
Apr 1, 2022
agnivade
approved these changes
Apr 2, 2022
isacikgoz
added
4: Reviews Complete
amyblais
added
Changelog/Not Needed
mylonsuren
pushed a commit
to mylonsuren/mattermost-server
that referenced
this pull request
Apr 5, 2022
Fork https://github.com/Masterminds/squirrel as https://github.com/lieut-data/squirrel with the following changes: * Masterminds/squirrel#256 supporting FROM clause to update builder (Postgres) * Extension of above to support multiple FROM in UPDATE (Postgres) * Support for multiple tables in UPDATE (MySQL) This PR then leverages those changes to simplify a query that previously had to be coded by hand and duplicate for each of MySQL and Postgres.
Willyfrog
pushed a commit
to Willyfrog/mattermost-server
that referenced
this pull request
Apr 8, 2022
Fork https://github.com/Masterminds/squirrel as https://github.com/lieut-data/squirrel with the following changes: * Masterminds/squirrel#256 supporting FROM clause to update builder (Postgres) * Extension of above to support multiple FROM in UPDATE (Postgres) * Support for multiple tables in UPDATE (MySQL) This PR then leverages those changes to simplify a query that previously had to be coded by hand and duplicate for each of MySQL and Postgres.
FreedomBen
pushed a commit
to FreedomBen/mattermost-server
that referenced
this pull request
Jun 14, 2022
Fork https://github.com/Masterminds/squirrel as https://github.com/lieut-data/squirrel with the following changes: * Masterminds/squirrel#256 supporting FROM clause to update builder (Postgres) * Extension of above to support multiple FROM in UPDATE (Postgres) * Support for multiple tables in UPDATE (MySQL) This PR then leverages those changes to simplify a query that previously had to be coded by hand and duplicate for each of MySQL and Postgres.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fork https://github.com/Masterminds/squirrel as https://github.com/lieut-data/squirrel with the following changes:
This PR then leverages those changes to simplify a query that previously had to be coded by hand and duplicate for each of MySQL and Postgres.
Ticket Link
None.
Release Note