PluginAPI: add ability to retrieve users by ids #26936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mm-cloud-bot
added
the
release-note
JulienTant
added
Docs/Needed
mgdelacroix
reviewed
May 3, 2024
| // ListByUserIDs gets users by their IDs. | ||
| // | ||
| // Minimum server version: 9.8 | ||
| func (u *UserService) ListByUserIDs(userIDs []string) ([]*model.User, error) { |
There was a problem hiding this comment.
Is there a reason to change from Get to List here? I think we should keep naming consistent if possible
There was a problem hiding this comment.
yeah, pluginapi uses List instead of Get for all lists.
There was a problem hiding this comment.
Ah, I see, let's be consistently inconsistent then :)
mgdelacroix
approved these changes
May 6, 2024
calebroseland
approved these changes
May 14, 2024
amyblais
added
Changelog/Done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a way in PluginAPI to retrieve users by ids
Ticket Link
N/A
Screenshots
N/A
Release Note