Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-57521] Profile button on hover shouldn't be red #26940

Closed

Conversation

kalil0321
Copy link

@kalil0321 kalil0321 commented May 1, 2024

Summary

When clicking your profile photo > then hovering over the profile button it isn't red anymore. Now there isn't any style on hover for the profile button.

Ticket Link

Fixes #26915
Jira https://mattermost.atlassian.net/browse/MM-57521

Screenshots

before after
mattermost-old mattermost-new

Release Note

NONE

@mm-cloud-bot mm-cloud-bot added the release-note-none Denotes a PR that doesn't merit a release note. label May 1, 2024
@mattermost-build
Copy link
Contributor

Hello @kalil0321,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@kalil0321 kalil0321 changed the title Profile onhover shouldnt be red [MM-57521] Profile button on hover shouldn't be red May 1, 2024
@hanzei hanzei requested a review from asaadmahmood May 6, 2024 07:34
@hanzei hanzei added 2: Dev Review Requires review by a developer 1. UX Review Requires review by a UX Designer labels May 6, 2024
Copy link
Contributor

@asaadmahmood asaadmahmood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kalil0321 kalil0321 closed this by deleting the head repository May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. UX Review Requires review by a UX Designer 2: Dev Review Requires review by a developer Contributor release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hovering over the Profile icon displays as red
5 participants