Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-57835] In Edit Message Adding emojis in between text while editing a post does not add emojis in the intended place. #26952

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[MM-57835] In Edit Message Adding emojis in between text while editing a post does not add emojis in the intended place. #26952

wants to merge 3 commits into from

Conversation

fasal26
Copy link
Contributor

@fasal26 fasal26 commented May 3, 2024 •
edited

Summary

Resolved emoji position issue while editing message

Ticket Link

Fixes #26914

Release Note

Fixed the position of emoji's while editing message/post

@mm-cloud-bot
Copy link

@fasal26: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

@mattermost-build
Copy link
Contributor

Hello @fasal26,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

@mm-cloud-bot mm-cloud-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed labels May 4, 2024
@hanzei hanzei added 2: Dev Review Requires review by a developer 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review labels May 6, 2024
@unified-ci-app
Copy link
Contributor

unified-ci-app bot commented May 6, 2024

Enterprise tests are not yet completed. You need to wait until Enterprise CI/docker-image status check is successful, before triggering E2E tests.

@M-ZubairAhmed M-ZubairAhmed changed the title [PR] emoji position issue while editing message [MM-57835] In Edit Message Adding emojis in between text while editing a post does not add emojis in the intended place. May 7, 2024
M-ZubairAhmed
M-ZubairAhmed requested changes May 7, 2024
View reviewed changes
Copy link
Member

@M-ZubairAhmed M-ZubairAhmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please check the failing CIs

marianunez
marianunez requested changes May 16, 2024
View reviewed changes
Copy link
Member

@marianunez marianunez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes to move off my queue while these are addressed. @fasal26 let us know if you need any help on this

@fasal26
Copy link
Contributor Author

fasal26 commented May 20, 2024

Resolved
Please verify @marianunez @M-ZubairAhmed

@M-ZubairAhmed M-ZubairAhmed added the Setup Cloud Test Server Setup an on-prem test server label May 20, 2024
@mm-cloud-bot
Copy link

Creating a new SpinWick test server using Mattermost Cloud.

@mm-cloud-bot
Copy link

Mattermost test server created! 🎉

Access here: https://mattermost-pr-26952.test.mattermost.cloud

Account Type Username Password
Admin sysadmin Sys@dmin123
User user-1 User-1@123

Your Spinwick's installation ID is: gegrtjuitigm5qrr4n846rkdpr
To access the logs, please click here

marianunez
marianunez approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@marianunez marianunez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fasal26!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marianunez marianunez marianunez approved these changes

@M-ZubairAhmed M-ZubairAhmed Awaiting requested review from M-ZubairAhmed

@yasserfaraazkhan yasserfaraazkhan Awaiting requested review from yasserfaraazkhan

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
2: Dev Review Requires review by a developer 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review Contributor release-note Denotes a PR that will be considered when it comes time to generate release notes. Setup Cloud Test Server Setup an on-prem test server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Edit Message | Adding emojis in between text while editing a post does not add emojis in the intended place.
6 participants
@fasal26 @mm-cloud-bot @mattermost-build @marianunez @M-ZubairAhmed @hanzei