Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-57877] Fix issue #26841 #26956

Merged
merged 5 commits into from May 13, 2024
Merged

[MM-57877] Fix issue #26841 #26956

merged 5 commits into from May 13, 2024

Conversation

MeHow25
Copy link
Contributor

@MeHow25 MeHow25 commented May 5, 2024

Summary

Display a clear and user-friendly message when the user tries to create a new team on an already existing URL.

Ticket Link

Fixes #26841
Jira https://mattermost.atlassian.net/browse/MM-57877

Screenshots

before after
image image

Release Note

Fix GH-26841

@mm-cloud-bot mm-cloud-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 5, 2024
@mattermost-build
Copy link
Contributor

Hello @MeHow25,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks for the contribution

@hanzei hanzei added 2: Dev Review Requires review by a developer 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review labels May 6, 2024
@unified-ci-app
Copy link
Contributor

unified-ci-app bot commented May 6, 2024

Enterprise tests are not yet completed. You need to wait until Enterprise CI/docker-image status check is successful, before triggering E2E tests.

Copy link
Member

@hmhealey hmhealey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This looks good to me. I was expecting this to be changed on the client-side because I thought the error was coming from a different method, but it makes more sense to me to handle it this way

@hmhealey hmhealey removed the 2: Dev Review Requires review by a developer label May 7, 2024
@yasserfaraazkhan
Copy link
Contributor

/update-branch

@yasserfaraazkhan yasserfaraazkhan added the Setup Cloud Test Server Setup an on-prem test server label May 8, 2024
Copy link
Contributor

@yasserfaraazkhan yasserfaraazkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hmhealey
I'm seeign this error message This URL is taken or unavailable. Please try another. when I try to create a team with same url.

image

@MeHow25
Copy link
Contributor Author

MeHow25 commented May 9, 2024

@yasserfaraazkhan Have you used the steps from the link below to reproduce this bug?

#26841 (comment)

  1. Create User No. 1.
  2. Create a team with the URL “/lorem” using that user, but do not invite anyone.
  3. Create User No. 2.
  4. As User No. 2, attempt to create a new team with the same URL “/lorem.”
  5. An error message stating “Must call update for existing team” will be displayed.

Copy link
Contributor

@yasserfaraazkhan yasserfaraazkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MeHow25
thank you! the error message is showing up.

image

@MeHow25
Copy link
Contributor Author

MeHow25 commented May 12, 2024

@hmhealey Hi, I see that the "Enterprise CI/tests" is failing, but I don't have access there. Should I fix something?

@hmhealey
Copy link
Member

It's failing because en.json is out of order because of the new string you added, but since we missed it during reviews, I should be able to just fix it now.

Thanks again for the PR for this!

@hmhealey hmhealey added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review labels May 13, 2024
@hmhealey hmhealey enabled auto-merge (squash) May 13, 2024 18:58
@hmhealey hmhealey merged commit 298fd6e into mattermost:master May 13, 2024
27 of 29 checks passed
@mattermost-build mattermost-build removed the Setup Cloud Test Server Setup an on-prem test server label May 13, 2024
@mm-cloud-bot
Copy link

Test server destroyed

1 similar comment
@mm-cloud-bot
Copy link

Test server destroyed

@amyblais amyblais added Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation labels May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Done Required changelog entry has been written Contributor Docs/Not Needed Does not require documentation release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attempting to create a team with the URL of an existing team shows the wrong error message
7 participants