Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential github action smells #26958

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix potential github action smells #26958

wants to merge 1 commit into from

Conversation

ceddy4395
Copy link

Summary

Hey! 馃檪
I want to contribute the following changes to your workflow:

  • Use permissions whenever using Github Token
  • Avoid jobs without timeouts
  • Avoid starting new workflow whilst the previous one is still running

(These changes are part of a research Study at TU Delft looking at GitHub Action Smells. Find out more)

Ticket Link

Screenshots

Release Note

NONE

@ceddy4395
Fix gha smells:
8ab0b59 
- Use permissions whenever using Github Token
- Avoid jobs without timeouts
- Avoid starting new workflow whilst the previous one is still running
@mm-cloud-bot mm-cloud-bot added the release-note-none Denotes a PR that doesn't merit a release note. label May 5, 2024
@mattermost-build
Copy link
Contributor

Hello @ceddy4395,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

@hanzei hanzei requested review from mvitale1989 and toninis May 6, 2024 07:25
@hanzei hanzei added 2: Dev Review Requires review by a developer 2: Infra Review Requires review by a SRE and removed 2: Dev Review Requires review by a developer labels May 6, 2024
@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@ceddy4395
Copy link
Author

/check-cla

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvitale1989 mvitale1989 Awaiting requested review from mvitale1989

@toninis toninis Awaiting requested review from toninis

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
2: Infra Review Requires review by a SRE Contributor Lifecycle/1:stale release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ceddy4395 @mattermost-build @hanzei @mm-cloud-bot