New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ctx usage in Client4 methods #26973
base: master
Are you sure you want to change the base?
Conversation
@pmokeev: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. I understand the commands that are listed here |
Hello @pmokeev, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project. Please help complete the Mattermost contribution license agreement? This is a standard procedure for many open source projects. Please let us know if you have any questions. We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team. |
/check-cla |
/release-note-none |
@hmhealey @devinbinnie can you have a look at this PR? |
Thanks for the PR! I'm actually going to reassign the reviewers on this to people who are more familiar with the server-side code |
Ben was driving the change around adding contexts. Will defer to him. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like there are other places as well where we can apply this change. Let's do all of them at once.
Summary
Replaced
http.NewRequest
method indoUploadFile
anduploadPlugin
functions byhttp.NewRequestWithContext
method, so now it uses context variable.Release Note