Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ctx usage in Client4 methods #26973

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pmokeev
Copy link

@pmokeev pmokeev commented May 8, 2024

Summary

Replaced http.NewRequest method in doUploadFile and uploadPlugin functions by http.NewRequestWithContext method, so now it uses context variable.

Release Note

NONE

@mm-cloud-bot
Copy link

@pmokeev: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

@mattermost-build
Copy link
Contributor

Hello @pmokeev,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

@pmokeev
Copy link
Author

pmokeev commented May 8, 2024

/check-cla

@pmokeev
Copy link
Author

pmokeev commented May 8, 2024

/release-note-none

@pmokeev
Copy link
Author

pmokeev commented May 14, 2024

@hmhealey @devinbinnie can you have a look at this PR?

@mm-cloud-bot mm-cloud-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed labels May 15, 2024
@hmhealey hmhealey added the 2: Dev Review Requires review by a developer label May 15, 2024
@hmhealey
Copy link
Member

Thanks for the PR! I'm actually going to reassign the reviewers on this to people who are more familiar with the server-side code

@hmhealey hmhealey requested review from agnivade and isacikgoz and removed request for hmhealey and devinbinnie May 15, 2024 20:07
@agnivade agnivade requested review from hanzei and removed request for agnivade May 16, 2024 04:52
@agnivade
Copy link
Member

Ben was driving the change around adding contexts. Will defer to him.

Copy link
Member

@agnivade agnivade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like there are other places as well where we can apply this change. Let's do all of them at once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a developer Contributor release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants