Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-57711] Convert ./components/latex_inline/latex_inline.tsx from Class Component to Function Component #26975

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

artemdev9
Copy link

@artemdev9 artemdev9 commented May 8, 2024

Summary

Migrated latex_inline.tsx from Class Component to Function Component.

QA Test Steps:
Paste: e^{i\pi} + 1 = 0 wrapped by $ into the textarea. The latex inline component will render.

Ticket Link

Fixes #26679
Jira https://mattermost.atlassian.net/browse/MM-57711

Release Note

None

@mm-cloud-bot
Copy link

@artemdev9: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

@mattermost-build
Copy link
Contributor

Hello @artemdev9,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Copy link
Contributor

@larkox larkox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! LGTM

@larkox larkox added 2: Dev Review Requires review by a developer 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review labels May 8, 2024
@unified-ci-app
Copy link
Contributor

unified-ci-app bot commented May 8, 2024

Enterprise tests are not yet completed. You need to wait until Enterprise CI/docker-image status check is successful, before triggering E2E tests.

@harshilsharma63
Copy link
Member

@artemdev9 can you fix the lint errors for the Web App CI PR / pr-ci / check-lint (pull_request) step in checks?

@artemdev9
Copy link
Author

@harshilsharma63 fixed lint errors.

@harshilsharma63
Copy link
Member

/update-branch

@larkox
Copy link
Contributor

larkox commented May 24, 2024

@artemdev9 The change in the test name has broken the snapshots. Just run npm run test -- -u and it should solve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a developer 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review Contributor do-not-merge/release-note-label-needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert ./components/latex_inline/latex_inline.tsx from Class Component to Function Component
5 participants