New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MM-57711] Convert ./components/latex_inline/latex_inline.tsx from Class Component to Function Component #26975
base: master
Are you sure you want to change the base?
Conversation
@artemdev9: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. I understand the commands that are listed here |
Hello @artemdev9, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! LGTM
Enterprise tests are not yet completed. You need to wait until |
@artemdev9 can you fix the lint errors for the |
@harshilsharma63 fixed lint errors. |
/update-branch |
@artemdev9 The change in the test name has broken the snapshots. Just run |
Summary
Migrated latex_inline.tsx from Class Component to Function Component.
QA Test Steps:
Paste: e^{i\pi} + 1 = 0 wrapped by $ into the textarea. The latex inline component will render.
Ticket Link
Fixes #26679
Jira https://mattermost.atlassian.net/browse/MM-57711
Release Note
None