Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MM-57882 Add metric for the time it takes to open the Threads list #26983

Merged
merged 4 commits into from May 21, 2024

Conversation

hmhealey
Copy link
Member

@hmhealey hmhealey commented May 9, 2024

Summary

Note that this only captures the time taken by clicking on the Threads item in the LHS, not switching via a hotkey or using the quick switcher. This matches how channel_switch and team_switch are measured as well.

Ticket Link

MM-57882

Release Note

Added a metric to track time it takes for the Threads view to load

@hmhealey hmhealey added the 2: Dev Review Requires review by a developer label May 9, 2024
@mm-cloud-bot mm-cloud-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 9, 2024
@hmhealey hmhealey added the Awaiting Submitter Action Blocked on the author label May 16, 2024
@hmhealey
Copy link
Member Author

Added "Awaiting Submitter Action" since I forgot to add the server-side code to collect these metrics in Prometheus

@hmhealey hmhealey added Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) and removed Awaiting Submitter Action Blocked on the author labels May 16, 2024
@hmhealey hmhealey changed the base branch from master to MM-58281_metrics-type May 16, 2024 16:28
@hmhealey hmhealey added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a developer labels May 16, 2024
@hmhealey hmhealey self-assigned this May 16, 2024
Base automatically changed from MM-58281_metrics-type to master May 16, 2024 18:01
@hmhealey
Copy link
Member Author

To avoid rebasing this repeatedly, this is currently blocked on #27046 and #27033

@hmhealey hmhealey removed the Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) label May 21, 2024
@hmhealey hmhealey merged commit 441f565 into master May 21, 2024
46 checks passed
@hmhealey hmhealey deleted the MM-57882_threads-metric branch May 21, 2024 22:04
@amyblais amyblais added Docs/Needed Requires documentation Changelog/Done Required changelog entry has been written labels May 21, 2024
@amyblais amyblais added this to the v9.10.0 milestone May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Done Required changelog entry has been written Docs/Needed Requires documentation release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants