Remove t from actions/invite_actions and components/invitation_modal #26988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not convinced that this was worth the time and effort to migrate even though I generally prefer defineMessages over defineMessage
mm-cloud-bot
added
the
release-note-none
BenCookie95
approved these changes
May 15, 2024
|
Whoops I forgot I submitted this already because I did this again in #27053. Given that one's passing CI, I'm going to go with that one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I decided to spend some time this afternoon on getting rid of
t.As much as I generally prefer
defineMessagesand having all the strings in one place, it really makes it difficult to read the diff when migrating existing code. I'm not sure if I'm going to keep using it when migrating busier files likeactions/invite_actionsin the future since it's much easier to follow a diff when usingdefineMessageinstead like in 65205bbRelease Note