Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null Safety #7

Merged
merged 8 commits into from Jul 1, 2021
Merged

Null Safety #7

merged 8 commits into from Jul 1, 2021

Conversation

josxha
Copy link
Contributor

@josxha josxha commented Apr 21, 2021

I have updated the package to unsound null safety because I needed it migrated to test my implementation.
However, I recommend to wait with merging this PR until a version with sound null safety is possible.

The following procedure is still missing for this:

  1. flutter_image must be migrated to sound null safety (https://github.com/flutter/flutter_image/pull/22)
  2. flutter_map must be migrated to sound null safety (Upgrade to sound null-safety fleaflet/flutter_map#870)
  3. the dependency_overrides entry must be removed in the pubspec.yaml file.

I tested my PR with the example app and my own application and I didn't notice any problems.

If you already want to use the null safety version, you can do so as follows:

dependencies:
  ....
  lat_lon_grid_plugin: any

dependency_overrides:
  lat_lon_grid_plugin:
    git:
      url: git://github.com/josxha/lat_lon_grid_plugin.git
      ref: 324bbb630af27829f47d30cad3e2fc4a97c29ef7

@josxha
Copy link
Contributor Author

josxha commented Jun 4, 2021

Just updated my pull request to use the published version of flutter_map from pub.dev. I will test the package again with my own implementation and the example project.

@josxha
Copy link
Contributor Author

josxha commented Jun 16, 2021

I have tested the package and everything runs without problems.
@mat8854 The pull request can now be merged and published to pub.dev if you find the time.

@matthiasdittmer matthiasdittmer merged commit 333c658 into matthiasdittmer:master Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants