WIP: Allow custom window functions to be registered #1216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closing in favor of a more "real" implementation! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR to discuss the desired interface and implementation for #1215
I've added a new function
RegisterWindowAggregatorthat is similar to (read: copy/pasted from)RegisterAggregator. An alternative would be to check that the interfaceimplimplements the two functions that windowing requiresInverseandValue.I'm unsure if it makes sense to use the type-embedded
windowAggInfo, or instead to consolidate this intoaggInfoOnce I get clarification on these two points I can make this PR more review-ready
Thanks for taking a look!