Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add base uri to http client created by integration factory #12760

Merged
merged 15 commits into from
Apr 25, 2024

Conversation

galvani
Copy link
Contributor

@galvani galvani commented Oct 2, 2023

Q A
New feature/enhancement? (use the a.x branch) [ ]

Description:

If you initiate an HTTP client through the integration's OAUTH HttpFactory, there is no way to set a base_uri, so every request needs the full URL in request. This allows the Credentials used to factor the client to set the base_uri config parameter.

Steps to test this PR:

As a developer you need to implement new HTTP client and try

Implemented test makes use of deprecated function, which won't be deprecated.
guzzle/guzzle#3114 (comment)

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.78%. Comparing base (51146d1) to head (f67e554).
Report is 1 commits behind head on 5.x.

❗ Current head f67e554 differs from pull request most recent head 05e213e. Consider uploading reports for the commit 05e213e to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                5.x   #12760      +/-   ##
============================================
- Coverage     61.39%   58.78%   -2.62%     
+ Complexity    34024    33161     -863     
============================================
  Files          2238     2198      -40     
  Lines        101686    99244    -2442     
============================================
- Hits          62432    58338    -4094     
- Misses        39254    40906    +1652     
Files Coverage Δ
...le/Auth/Provider/Oauth2ThreeLegged/HttpFactory.php 98.38% <100.00%> (+0.08%) ⬆️

... and 486 files with indirect coverage changes

@galvani galvani force-pushed the integration-oauth-client-base-uri branch 3 times, most recently from 7dea594 to 3b6fc48 Compare January 18, 2024 14:49
@galvani galvani force-pushed the integration-oauth-client-base-uri branch from 3b6fc48 to bb67361 Compare January 18, 2024 14:55
@galvani galvani marked this pull request as ready for review January 18, 2024 15:03
kuzmany
kuzmany previously approved these changes Jan 19, 2024
Copy link
Member

@kuzmany kuzmany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, make sense

@kuzmany kuzmany added the pending-test-confirmation PR's that require one test before they can be merged label Jan 19, 2024
@RCheesley RCheesley added T2 Medium difficulty to fix (issue) or test (PR) bug Issues or PR's relating to bugs plugin Anything related to plugins code-review-needed PR's that require a code review before merging labels Jan 31, 2024
Copy link
Contributor

@nick-vanpraet nick-vanpraet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks clean

@kuzmany kuzmany mentioned this pull request Feb 1, 2024
@escopecz escopecz added code-review-passed PRs which have passed code review and removed code-review-needed PR's that require a code review before merging pending-test-confirmation PR's that require one test before they can be merged labels Apr 24, 2024
@escopecz escopecz added this to the 5.1.0 milestone Apr 24, 2024
@escopecz escopecz added the ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged label Apr 24, 2024
@escopecz escopecz merged commit c4a1602 into mautic:5.x Apr 25, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs code-review-passed PRs which have passed code review plugin Anything related to plugins ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged T2 Medium difficulty to fix (issue) or test (PR)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants