-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add base uri to http client created by integration factory #12760
add base uri to http client created by integration factory #12760
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 5.x #12760 +/- ##
============================================
- Coverage 61.39% 58.78% -2.62%
+ Complexity 34024 33161 -863
============================================
Files 2238 2198 -40
Lines 101686 99244 -2442
============================================
- Hits 62432 58338 -4094
- Misses 39254 40906 +1652
|
…ration-oauth-client-base-uri
7dea594
to
3b6fc48
Compare
3b6fc48
to
bb67361
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, make sense
…i/mautic into integration-oauth-client-base-uri
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks clean
Description:
If you initiate an HTTP client through the integration's OAUTH HttpFactory, there is no way to set a base_uri, so every request needs the full URL in request. This allows the Credentials used to factor the client to set the base_uri config parameter.
Steps to test this PR:
As a developer you need to implement new HTTP client and try
Implemented test makes use of deprecated function, which won't be deprecated.
guzzle/guzzle#3114 (comment)