Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: stream: pipeline: Fix wrong frame duration #353

Merged
merged 2 commits into from Mar 9, 2024
Merged

src: stream: pipeline: Fix wrong frame duration #353

merged 2 commits into from Mar 9, 2024

Conversation

joaoantoniocardoso
Copy link
Collaborator

@joaoantoniocardoso joaoantoniocardoso commented Mar 8, 2024 •
edited

This patch:

  • Fixes the frame duration, which fixes the FPS reported from different applications when a video is recorded from our WebRTC.
  • might help this Cockpit issue.

Verification

From ffprobe:

image

From YUYView (before):

Stream Info for before.webm:

image

Stream Info for before.mkv:

image

Packet Analysis for before.mkv:

image

From YUYView (after):

Stream Info for after.webm:

image

Stream Info for after.mkv:

image

Packet Analysis for after.mkv:

image

@patrickelectric patrickelectric merged commit 486d295 into mavlink:master Mar 9, 2024
4 checks passed
@joaoantoniocardoso joaoantoniocardoso deleted the fix_h264_frames_duration branch March 9, 2024 04:03
@rafaellehmkuhl rafaellehmkuhl mentioned this pull request Mar 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickelectric patrickelectric patrickelectric approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joaoantoniocardoso @patrickelectric