Fix stream recreation logic, prefer Interval::tick to time::sleep in tokio loops #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-172
to
-174
| if let Some(reason) = finish.recv().await { | ||
| return Err(anyhow!("{reason:?}")); | ||
| } |
There was a problem hiding this comment.
If not clear, the wrong logic was here. We were only going to the if below (which triggers the stream recreation process) after this future ends, which would only be Some(reason), which would return, or None (closed), which would not necessarily happen.
patrickelectric
approved these changes
Mar 15, 2024
joaoantoniocardoso
deleted the
prefer_interval_over_sleep_for_periodic_loops
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.