New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: add EditorConfig and format some files #2106
style: add EditorConfig and format some files #2106
Conversation
I checked files with grep and find to see what extensions there were, which files used what conventions and tried to add all the conventions in the EditorConfig file to enforce a more consistent style in the future. I also limited Having this file is especially handy when this code is used as a submodule where another EditorConfig file might set different settings. The editor always uses the EditorConfig that is closest to the edited file, which would be the one added here. |
@flyingthingsintothings Thank you so much - this is great. In particular, should fix some of those spurious formatting errors when working with new message definitions, @julianoes I'm approving. But good to have a second pair of eyes so would appreciate you could do a check too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine with me.
@hamishwillee would be nice if your editor wouldn't leave trailing whitespace on save. |
Add an EditorConfig to make sure editors know how to correctly edit and save files. Also strip trailing whitespace in some files that don't need it, as configured in the EditorConfig file.
9becfc3
to
6c069e3
Compare
I added some rules to remove trailing whitespace on save but didn't do it for all files as I know it can be meaningful in some languages. |
It certainly would :-) Thanks @flyingthingsintothings - merging. |
Add an EditorConfig to make sure editors know how to correctly edit and save files. Also strip trailing whitespace in some files that don't need it, as configured in the EditorConfig file.