Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused isArray polyfill #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kenany
Copy link

@kenany kenany commented Nov 11, 2014

Not being used anywhere. Or, should it be used here?

@shinnn
Copy link
Contributor

shinnn commented Jun 10, 2015

👍 for just removing it. Users can add another isArray polyfill as needed.

@stevemao
Copy link

👍

@ljharb
Copy link
Contributor

ljharb commented Apr 15, 2016

better to use the isarray module.

@kenany kenany mentioned this pull request Nov 11, 2016
@eagleeye
Copy link

eagleeye commented Jun 8, 2017

@maxogden @mafintosh how about merging this?

@ljharb
Copy link
Contributor

ljharb commented Jun 8, 2017

#32 (comment)

@kenany
Copy link
Author

kenany commented Jun 8, 2017

Could also do that if desired (note, that specific module is deprecated, but there are others).

@ljharb
Copy link
Contributor

ljharb commented Jun 8, 2017

That deprecation only applies to v2, and is simply a paternalistic way of trying to push people not to support ES3. You can and should use v1 of that package for the foreseeable future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants