This repository has been archived by the owner on May 17, 2023. It is now read-only.
fix: armv7 openssl no asm #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdcastro
reviewed
Jul 14, 2021
Co-authored-by: Paulo Castro <paulo@balena.io>
|
I'm currently building this and pushing to my dockerhub, I'd like @pdcastro to test out the binaries when they are ready before this gets merged. |
I've only tested v12.22.3 but it was good, 🎉 so I think this PR can be merged. Thank you for your effort! 💯 Alas, my testing also revealed another issue, that may mean I cannot use statically compiled Node.js binaries at all, on any platform: leafac/caxa#30 (comment) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6