\capricorn86#1010@patch: Check HTMLButtonElementNamedNodeMap removedI…

…tem is defined before accessing properties.
maxmilton · Aug 4, 2023 · e62d2fd · e62d2fd
1 parent 941b6df
commit e62d2fd
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/packages/happy-dom/src/nodes/html-button-element/HTMLButtonElementNamedNodeMap.ts b/packages/happy-dom/src/nodes/html-button-element/HTMLButtonElementNamedNodeMap.ts
@@ -42,6 +42,7 @@ export default class HTMLButtonElementNamedNodeMap extends HTMLElementNamedNodeM
 		const removedItem = super.removeNamedItem(name);
 
 		if (
+			removedItem &&
 			(removedItem.name === 'id' || removedItem.name === 'name') &&
 			this._ownerElement._formNode
 		) {

diff --git a/packages/happy-dom/test/nodes/html-button-element/HTMLButtonElement.test.ts b/packages/happy-dom/test/nodes/html-button-element/HTMLButtonElement.test.ts
@@ -75,7 +75,12 @@ describe('HTMLButtonElement', () => {
 	});
 
 	describe(`set disabled()`, () => {
-		it('Sets attribute value.', () => {
+		it('Sets attribute value to false.', () => {
+			element.disabled = false;
+			expect(element.getAttribute('disabled')).toBe(null);
+		});
+
+		it('Sets attribute value to true.', () => {
 			element.disabled = true;
 			expect(element.getAttribute('disabled')).toBe('');
 		});