Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation to Chinese #15

Open
BirkhoffLee opened this issue Sep 21, 2017 · 10 comments
Open

Translation to Chinese #15

BirkhoffLee opened this issue Sep 21, 2017 · 10 comments

Comments

@BirkhoffLee
Copy link

BirkhoffLee commented Sep 21, 2017

Hey there! Thanks for the nice cheatsheet. Is there any chance that I can help translate it to Chinese(Traditional)?

@mbeaudru
Copy link
Owner

Hi @BirkhoffLee ! Yes, you can help translate it to Chinese 👍. To do so, you have to do a fork and a pull request.

The workflow basically consists to create a copy of this repo on your account (fork), create a new file and begin the translation. When you want to submit it to me you ask for a pull request.

By the way, thanks for your positive feedback and for your willingness to participate 👍 💯

@mbeaudru
Copy link
Owner

Don't know why I closed it in the first place 😅

@mbeaudru mbeaudru reopened this Sep 22, 2017
@soyaine
Copy link
Contributor

soyaine commented Sep 22, 2017

Hi, @BirkhoffLee! I am also ready to translate this cheat sheet.
How do you think if we create two different files to translate, one for Traditional and the other for Simplified?

@BirkhoffLee
Copy link
Author

BirkhoffLee commented Sep 22, 2017 via email

@mbeaudru
Copy link
Owner

mbeaudru commented Sep 22, 2017

I've checked your fork quickly, if I may I suggest you to update the readme because there has been a lot of modifications since last time. Things were not right and have been fixed now. At this point you should be safe tough 👍 .

Thanks again for your time guys 💯

@BirkhoffLee
Copy link
Author

BirkhoffLee commented Sep 22, 2017 via email

@rolisanchez
Copy link

Hi @mbeaudru. Perhaps you could open some issues with the tag Hacktoberfest (https://hacktoberfest.digitalocean.com) to translate this cheatsheet to other languages. Seems like a cool cheatsheet, some people could help translating to other languages. I
By the way @BirkhoffLee, just saw there is a Chinese translation already:
https://github.com/WeiChiaChang/modern-js-cheatsheet

@BirkhoffLee
Copy link
Author

BirkhoffLee commented Sep 28, 2017

Oh, thanks for the discovery @rolisanchez , then I think I'll just stop translating :)
Should I close this issue now?

@mbeaudru
Copy link
Owner

mbeaudru commented Sep 29, 2017

@BirkhoffLee No you can let it opened ! The translation has not been added to this repo so the issue remains 👍 .

Look what I said to @soyaine here 😄 .

By the way, thanks again for contributing. Maybe there are mistakes in the translation you could fix, or other ways to say things. There is room for your contribution.

@WeiChiaChang
Copy link
Contributor

WeiChiaChang commented Sep 29, 2017

Hello @mbeaudru, thanks for providing this document, really do a great help on learning ES6.

One thing I have to say sorry to @BirkhoffLee at first since I didn't find you already have willing to translate it into traditional Chinese version until I received the email reminder from @soyaine 😭.

email

Last but not least, in these one or two days, I will double check the whole document for syntax and translation part mostly before sending a Pull Request to @mbeaudru . Thanks again for all of you to make modern-js-cheatsheet better !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants