-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] Enable parametrisation of dynamic data functions #482
Conversation
… figure["data_frame"]. Seems to work ok
… don't enable for now" This reverts commit 92e6c68.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…atalog.yaml Signed-off-by: Antony Milne <49395058+antonymilne@users.noreply.github.com>
vizro-core/changelog.d/20240514_213231_antony.milne_dynamic_data_load_with_args.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a few minor suggestions but approving from docs perspective since I'll be unavailable until Wednesday 29th.
Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com>
Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com>
Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com>
…rametrise-dynamic-data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐ Really cool work you two ⭐
Tried to review as carefully as possible, and only found small things where I suggested smth.
Very exciting stuff that will enable a whole range of new usage options.
…rametrise-dynamic-data
for more information, see https://pre-commit.ci
Description
Completing https://github.com/McK-Internal/vizro-internal/issues/753
Builds on #479 (step 1 of 2)
This PR enables dynamic data function arguments to be parametrised by using
vm.Parameter
(parameter targets in a format:<target_component>.data_frame.<dynamic_data_argument>
).The focus of this PR is writing docs, unit tests, making the export_data action to take this type of parameter into account. So the refactoring changes in the
/actions
folder don't need to be reviewed in detail.Comment out the following configuration inside
vizro-core/hatch.toml
in case you get a better idea of what happens when caching is enabled.TODO
TestCacheWithArguments.test_timeout_expires_all
-> A potential solution [QA] Fix flakydata_manager
unit tests #497Screenshot
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":