-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Update Vizro docs to use Inter Font #483
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed font to Inter for Vizro-ai Signed-off-by: Syed Affan D. <73064995+sulphatet@users.noreply.github.com>
Signed-off-by: Syed Affan D. <73064995+sulphatet@users.noreply.github.com>
sulphatet
requested review from
Joseph-Perkins,
Anna-Xiong,
lingyielia,
maxschulz-COL,
antonymilne and
huong-li-nguyen
as code owners
May 15, 2024 15:41
stichbury
approved these changes
May 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @sulphatet -- this is awesome! It's a minor change but it's exactly what was needed. Approving 🌟
stichbury
had a problem deploying
to
vizro_ai_secrets
May 20, 2024 12:14
— with
GitHub Actions
Failure
stichbury
had a problem deploying
to
vizro_ai_secrets
May 20, 2024 12:14
— with
GitHub Actions
Failure
stichbury
had a problem deploying
to
vizro_ai_secrets
May 20, 2024 12:14
— with
GitHub Actions
Failure
stichbury
had a problem deploying
to
vizro_ai_secrets
May 20, 2024 12:14
— with
GitHub Actions
Failure
stichbury
had a problem deploying
to
vizro_ai_secrets
May 20, 2024 12:14
— with
GitHub Actions
Failure
Joseph-Perkins
approved these changes
May 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brilliant! thank you 😁
stichbury
had a problem deploying
to
vizro_ai_secrets
May 21, 2024 08:09
— with
GitHub Actions
Failure
stichbury
had a problem deploying
to
vizro_ai_secrets
May 21, 2024 08:09
— with
GitHub Actions
Failure
stichbury
had a problem deploying
to
vizro_ai_secrets
May 21, 2024 08:09
— with
GitHub Actions
Failure
stichbury
had a problem deploying
to
vizro_ai_secrets
May 21, 2024 08:09
— with
GitHub Actions
Failure
stichbury
had a problem deploying
to
vizro_ai_secrets
May 21, 2024 08:09
— with
GitHub Actions
Failure
huong-li-nguyen
changed the title
Updated Vizro docs to use Inter Font
[Docs] Update Vizro docs to use Inter Font
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on the discussion here I have made updates to the yaml files used by MkDocs to convert the Roboto font to the Inter font family for vizro-core and vizro-ai.
Screenshot
Before
After
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":