Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Github tests trigger for CircleCI #484

Merged
merged 39 commits into from
May 27, 2024
Merged

Conversation

l0uden
Copy link
Contributor

@l0uden l0uden commented May 15, 2024

Description

Here we'll get rid of CircleCI pipeline for vizro repo.
New GitHub Action will trigger tests pipeline instead.

test-integration-vizro-ai and CircleCI tests trigger GitHub Actions will always pass for the forked repos.

test-integration-vizro-ai will run for every push to vizro-ai folder except docs. And will run for every merge to main for changes in any folder.

Connected with https://github.com/mckinsey/vizro-qa/pull/89

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
    • I have not referenced individuals, products or companies in any commits, directly or indirectly.
    • I have not added data or restricted code in any commits, directly or indirectly.

@l0uden l0uden temporarily deployed to circleci_secrets May 15, 2024 16:36 — with GitHub Actions Inactive
…to ci/move_ci_trigger_to_github

# Conflicts:
#	.github/workflows/circleci-trigger.yml
…to ci/move_ci_trigger_to_github

# Conflicts:
#	.github/workflows/circleci-trigger.yml
@l0uden l0uden temporarily deployed to circleci_secrets May 15, 2024 16:56 — with GitHub Actions Inactive
@l0uden l0uden temporarily deployed to circleci_secrets May 22, 2024 10:06 — with GitHub Actions Inactive
@l0uden l0uden temporarily deployed to circleci_secrets May 22, 2024 11:25 — with GitHub Actions Inactive
@l0uden l0uden temporarily deployed to circleci_secrets May 22, 2024 11:41 — with GitHub Actions Inactive
@l0uden l0uden temporarily deployed to circleci_secrets May 22, 2024 11:55 — with GitHub Actions Inactive
@l0uden l0uden temporarily deployed to circleci_secrets May 23, 2024 13:17 — with GitHub Actions Inactive
Copy link
Contributor

@antonymilne antonymilne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for all your work on this @l0uden.

I made a few small commits just to make it more consistent with how we do other GHA on this repo:

  1. Small renaming - not important
  2. Remove remaining references to tag and unnecessary arguments - this one is the only bit that changes functionality. I think when you removed the tag stuff you forgot to remove some parts, so please check this
  3. Tiny refactor - not important

If you're happy I didn't break anything here then I'm happy for you to merge whenever. I just did a quick test and it seems to work ok.

@l0uden l0uden temporarily deployed to circleci_secrets May 24, 2024 09:51 — with GitHub Actions Inactive
@l0uden l0uden temporarily deployed to circleci_secrets May 27, 2024 16:37 — with GitHub Actions Inactive
@l0uden l0uden merged commit f0a184b into main May 27, 2024
32 of 33 checks passed
@l0uden l0uden deleted the ci/move_ci_trigger_to_github branch May 27, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Tests 🧪 Issue/PR that address test framework Status: Ready for Review ☑️ Issue/PR is ready for review - all tests have passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants