Correctly count non-00 statusCodes

lib/run.js

@@ -100,7 +100,7 @@ function run (opts, cb) {
 
   function onResponse (statusCode, resBytes, responseTime) {
     tracker.emit('response', this, statusCode, resBytes, responseTime)
-    const codeIndex = (parseInt(statusCode) / 100) - 1
+    const codeIndex = Math.floor(parseInt(statusCode) / 100) - 1
     statusCodes[codeIndex] += 1
     // only record 2xx latencies
     if (codeIndex === 1) latencies.record(responseTime)

test/helper.js

@@ -5,12 +5,16 @@ const https = require('https')
 const fs = require('fs')
 const path = require('path')
 
-function startServer () {
+function startServer (opts) {
+  opts = opts || {}
+
+  const statusCode = opts.statusCode || 200
   const server = http.createServer(handle)
 
   server.listen(0)
 
   function handle (req, res) {
+    res.statusCode = statusCode
     res.end('hello world')
   }
 
@@ -67,23 +71,6 @@ function startHttpsServer () {
   return server
 }
 
-for (let i = 1; i <= 5; i++) {
-  module.exports[`start${i}xxServer`] = function () {
-    const server = http.createServer(handle)
-
-    server.listen(0)
-
-    function handle (req, res) {
-      res.writeHead(Number(`${i}00`))
-      res.end()
-    }
-
-    server.unref()
-
-    return server
-  }
-}
-
 module.exports.startServer = startServer
 module.exports.startTimeoutServer = startTimeoutServer
 module.exports.startHttpsServer = startHttpsServer

test/run.test.js

@@ -207,7 +207,8 @@ test('run should allow users to enter timestrings to be used for duration', (t)
 for (let i = 1; i <= 5; i++) {
   test(`run should count all ${i}xx status codes`, (t) => {
     t.plan(2)
-    const server = helper[`start${i}xxServer`]()
+
+    const server = helper.startServer({ statusCode: i * 100 + 2 })
 
     run({
       url: `http://localhost:${server.address().port}`,