Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: run to completion #57

Merged
merged 5 commits into from
Sep 10, 2021
Merged

feat: run to completion #57

merged 5 commits into from
Sep 10, 2021

Conversation

gillesdemey
Copy link
Contributor

This essentially adds a simple helper function to wait for the queueAsPromised to be drained, quite useful if fastq is used as a Promise.all() function but with concurrency.

Fixes #47

mcollina
mcollina approved these changes Sep 10, 2021
View reviewed changes
Copy link
Owner

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, good work!

@mcollina mcollina merged commit 9435e99 into mcollina:master Sep 10, 2021
@gillesdemey gillesdemey deleted the feat/runToCompletion branch September 10, 2021 14:27
@renovate renovate bot mentioned this pull request Dec 29, 2021
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Waiting for the queue to be fully processed
2 participants
@gillesdemey @mcollina