Skip to content

Commit

Permalink
Updates to all dependencies
Browse files Browse the repository at this point in the history
- Fixes for latest version of async which introduced breaking change --> caolan/async#1641
- Removed ignore dep from .ncurc.json as all issues have been resolved
- Following dependencies were updated:
 async          2.6.2  →   3.1.0
 node-rdkafka   2.6.1  →   2.7.1
 raw-body       2.4.0  →   2.4.1
 sinon          7.2.4  →   7.4.2
 tap-xunit      2.3.0  →   2.4.1
 tape          4.10.1  →  4.11.0
  • Loading branch information
mdebarros committed Sep 16, 2019
1 parent 0eaba67 commit 9fe802e
Show file tree
Hide file tree
Showing 4 changed files with 57 additions and 89 deletions.
9 changes: 1 addition & 8 deletions .ncurc.json
@@ -1,11 +1,4 @@
{
"reject": [
"async",
"sinon",
"events",
"node-rdkafka",
"raw-body",
"tap-xunit",
"tape"
]
}
}
121 changes: 48 additions & 73 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions package.json
Expand Up @@ -44,25 +44,25 @@
},
"dependencies": {
"@mojaloop/central-services-logger": "8.1.1",
"async": "2.6.2",
"async": "3.1.0",
"base64url": "3.0.1",
"clone": "2.1.2",
"data-urls": "1.1.0",
"debug": "4.1.1",
"events": "3.0.0",
"node-rdkafka": "2.6.1",
"raw-body": "2.4.0"
"node-rdkafka": "2.7.1",
"raw-body": "2.4.1"
},
"devDependencies": {
"faucet": "0.0.1",
"nyc": "14.1.1",
"npm-audit-resolver": "1.5.0",
"npm-check-updates": "3.1.23",
"pre-commit": "1.2.2",
"sinon": "7.2.4",
"sinon": "7.4.2",
"standard": "14.3.0",
"tap-xunit": "2.3.0",
"tape": "4.10.1",
"tap-xunit": "2.4.1",
"tape": "4.11.0",
"tapes": "4.1.0"
},
"publishConfig": {
Expand Down
4 changes: 2 additions & 2 deletions src/kafka/consumer.js
Expand Up @@ -406,9 +406,9 @@ class Consumer extends EventEmitter {
}, 1)

// a callback function, invoked when queue is empty.
this._syncQueue.drain = () => {
this._syncQueue.drain(() => {
this._consumer.resume(this._topics) // resume listening new messages from the Kafka consumer group
}
})
}

switch (this._config.options.mode) {
Expand Down

0 comments on commit 9fe802e

Please sign in to comment.