Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(css): Add CSS Values Level 4 abs() compatibility data #10552

Merged
merged 3 commits into from Sep 25, 2022

Conversation

ramiy
Copy link
Contributor

@ramiy ramiy commented May 20, 2021

Add browser compatibility data for the CSS abs() function to contain the new additions from CSS Values and Units Level 4.

Related: mdn/content#5168

@github-actions github-actions bot added the data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label May 20, 2021
@ramiy ramiy changed the title feat(css): Add CSS Values Level 4 abs() compatibility data feat(css): Add CSS Values Level 4 abs() compatibility data May 20, 2021
@ddbeck ddbeck added the not ready ⛔ This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action. label May 27, 2021
@ddbeck
Copy link
Collaborator

ddbeck commented May 27, 2021

Setting as not ready because this is blocked by #10619.

@saschanaz
Copy link
Contributor

That's added via w3c/csswg-drafts@8e3fb63 by @tabatkins, but interestingly not via a pull request and I don't see any tracking issues for browser implementations. Not sure what's going on there 🤔

@tabatkins
Copy link

I'm not sure what you think I'm supposed to have done here? abs() was added as part of the larger suite of new math functions, discussed and resolved on in a previous CSS face-to-face meeting.

@saschanaz
Copy link
Contributor

I wanted to check interest from implementers, and couldn't do it from the commit itself. What's the best way to track such thing?

@tabatkins
Copy link

Depends on what level of "interest" you want. It was part of the suite of math functions approved at the CSSWG face-to-face, and has the same level of approval/interest as sin()/etc. Minutes are recorded at https://lists.w3.org/Archives/Public/www-style/2020Feb/0007.html

@ramiy
Copy link
Contributor Author

ramiy commented May 29, 2021

Guys, I'm planning to create MDN pages for all the CSS Math functions. I need to know whether to create BCD json files for those functions. Note that no browser support them, yet. But I'm planning to nag the browser dev teams to implement them.

@queengooborg
Copy link
Collaborator

Hey @ramiy, thank you for your patience on this -- while we are still deciding whether to allow or disallow all-false features in BCD, a new spec-url meta tag has been added to content files, which can be used for features that aren't in BCD for one reason or another. This could be used here for these functions, if browser support is still all false!

@queengooborg
Copy link
Collaborator

Hey again, thank you for your patience on this! We have decided not to include features that have no compatibility in BCD. A spec may implement a feature, but then rename or remove it before any browsers implement it, thus leaving a leftover statement in BCD.

Would you be down to research if any browsers support this feature now? If not, I'd be happy to look into it and follow up!

@ramiy
Copy link
Contributor Author

ramiy commented Sep 23, 2022

Hi @queengooborg @ddbeck @wbamberg,

Looks like WebKit implemented this function. See bug #229786: Implement abs,sign calc functions (Sep 2021)

Also, according to the Web Platform Tests Dashboard, the function works:

But I couldn't find any mention in official releases.

@saschanaz
Copy link
Contributor

Nice find! CSS.supports("width: abs(20% - 100px)") reports true already on Safari 15.6.

@ramiy
Copy link
Contributor Author

ramiy commented Sep 23, 2022

@saschanaz

Web Platform Tests allows you to edit the search and specify the specific browser versions.

I checked all the available Safari versions. Version 15.4 is the first version to add support for abs() and sign() functions.

Ref: https://wpt.fyi/results/css/css-values?label=master&label=stable&product=chrome&product=edge&product=firefox&product=safari-15.4%20%2816613.1.17.1.11%29&aligned&view=subtest&q=sign

Before that, no support.

Ref: https://wpt.fyi/results/css/css-values?label=master&label=stable&product=chrome&product=edge&product=firefox&product=safari-15.3%20%2815612.4.9.1.8%29&aligned&view=subtest&q=sign

@ramiy
Copy link
Contributor Author

ramiy commented Sep 23, 2022

Moving the conversation to #17868

@ramiy
Copy link
Contributor Author

ramiy commented Sep 24, 2022

@queengooborg

See Safari 15.3 vs. Safari 15.4 support in web platform tests.

@queengooborg queengooborg removed the not ready ⛔ This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action. label Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants