WebExtension tweaks for Safari and Manifest V3 #17532
Conversation
github-actions
bot
added
the
data:webext 🎲
xeenon
force-pushed
the
safari-extension-tweaks
branch
4 times, most recently
from
e340e37
to
39bfa2b
Compare
|
@queengooborg let me know if this is okay, or if there are somethings I should do differently. |
|
Throughout MDN, the terms "required" and "optional" are used more frequently than "mandatory" -- could we keep using the term "required" and replace "not required"/"not mandatory" with optional? |
xeenon
force-pushed
the
safari-extension-tweaks
branch
from
39bfa2b
to
b99e5e0
Compare
| }, | ||
| { | ||
| "version_added": "42", | ||
| "alternative_name": "applications", |
There was a problem hiding this comment.
This alternative_name was a dummy entry to allow per-version notes here. I removed it to avoid confusion.
xeenon
force-pushed
the
safari-extension-tweaks
branch
from
b99e5e0
to
88853fe
Compare
* Features that are dropped in V3 noted as "Manifest V2 only". * Features that are added in V3 noted as "Manifest V3 or later" to avoid prematurely limiting to V3 when future versions are supported. * Features that are dropped in V3 by some browsers but are supported in full in others still noted as "Manifest V2 or later".
xeenon
force-pushed
the
safari-extension-tweaks
branch
from
88853fe
to
8f0f5d4
Compare
|
Rebased and ready to merge when you can, thanks @queengooborg! |
|
By the way, no need to rebase and force push for BCD PRs -- we squash merge all pull requests to this repository! |
| ], | ||
| "firefox": { | ||
| "version_added": "42", | ||
| "notes": "Before Firefox 48, this property was required." | ||
| }, |
There was a problem hiding this comment.
Why has this been changed? This breaks some of our tools and it took me a while to figure that out since it is not mentioned anywhere in the changelog. This patch is for Safari, it would have been good to not change Firefox data or to move these changes to a separate issue/PR.
There was a problem hiding this comment.
This PR is actually for Manifest V3 entirely as well, and if you look at the diff, you'll notice that this is simply consolidating the statements together to adhere to the typical structure of BCD (where a behavioral difference that only applies to one browser should be a single note, rather than two separated statements).
We apologize in advance for the changes causing an issue with your tooling; however, please do note that features may be added, removed or modified at any time to match developer interest, BCD data guidelines, or for better accuracy, as explained in the Semantic versioning policy. In other words, changes such as this are expected to happen in any release and will not result in any changelog notes.
runtime.getFrameIdand drop STP reference.