Add back pointerlock{error|change} events #17816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:api 🐇
This was referenced Sep 16, 2022
|
@foolip given #16674 (review) and #17821 can you say if this should live under |
|
This was a mishap in #16674. These two events were deleted, but not added anywhere else. Everything else lines up, so this PR should sort it out. |
|
I've also checked Chromium source to confirm the event ends up fired on |
foolip
requested changes
Sep 19, 2022
api/Element.json
Outdated
| @@ -6183,6 +6183,136 @@ | |||
| } | |||
| } | |||
| }, | |||
| "pointerlockchange_event": { | |||
api/Element.json
Outdated
Comment on lines
6233
to
6242
| "webview_android": [ | ||
| { | ||
| "version_added": "37" | ||
| }, | ||
| { | ||
| "version_added": "≤37", | ||
| "version_removed": "38", | ||
| "prefix": "webkit" | ||
| } | ||
| ] |
There was a problem hiding this comment.
Suggested change
| "webview_android": [ | |
| { | |
| "version_added": "37" | |
| }, | |
| { | |
| "version_added": "≤37", | |
| "version_removed": "38", | |
| "prefix": "webkit" | |
| } | |
| ] | |
| "webview_android": "mirror" |
api/Element.json
Outdated
Comment on lines
6298
to
6307
| "webview_android": [ | ||
| { | ||
| "version_added": "37" | ||
| }, | ||
| { | ||
| "version_added": "≤37", | ||
| "version_removed": "38", | ||
| "prefix": "webkit" | ||
| } | ||
| ] |
There was a problem hiding this comment.
Suggested change
| "webview_android": [ | |
| { | |
| "version_added": "37" | |
| }, | |
| { | |
| "version_added": "≤37", | |
| "version_removed": "38", | |
| "prefix": "webkit" | |
| } | |
| ] | |
| "webview_android": "mirror" |
|
As an aside, w3c/pointerlock#21 is a suggestion in the spec to fire the event on |
|
Updated. Fixing the content page, too. |
foolip
approved these changes
Sep 19, 2022
|
Content PR was merged. Merging this, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#16674 removed the
pointerlockchangeandpointerlockerrorevents fromapi/Document.json.I think the idea was to move them to
api/Element.json, so this PR adds them back toElement.Test results and supporting details
https://developer.mozilla.org/en-US/docs/Web/API/Document/pointerlockerror_event and
https://developer.mozilla.org/en-US/docs/Web/API/Document/pointerlockchange_event have broken compat tables (and the pages need to move to Element).
MDN content PR is mdn/content#20806