Remove @viewport #17860
Merged
Remove @viewport #17860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
data:css 🎨
|
This pull request has merge conflicts that must be resolved before it can be merged. |
Elchi3
changed the title
github-actions
bot
removed
data:html 📄
|
The issue in #17859 was solved within that PR. I guess we could still remove |
queengooborg
approved these changes
Sep 24, 2022
There was a problem hiding this comment.
I'm down to remove this, I don't trust that the Chromium browser forks still support it. Apologies for the merge conflicts, I didn't see this PR before working on the fixes!
(P.S. I also realize I didn't make the right changes to the HTML element, and simply removed the link rather than pointing to the new spec. We should probably add that updated link back in, what do you think?)
queengooborg
added
the
needs content update 📝
queengooborg
removed
the
needs content update 📝
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new browser-specs version fails. #17859
w3c/browser-specs#711
I think the correct thing to do is to remove
@viewportgiven it is not implemented anymore.