Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update compat data for mfrac@linethickness #17920

Merged
merged 2 commits into from Sep 30, 2022
Merged

Update compat data for mfrac@linethickness #17920

merged 2 commits into from Sep 30, 2022

Conversation

fred-wang
Copy link
Contributor

This commit updates compat data for the linethickness attribute of the element:

  • Replace notes about partial implementation in Safari with the use of of array of implementations.
  • Use "mirror" for Safari iOS, its MathML implementation matches the macOS one.
  • Add a subfeature for deprecated named values thin, medium, thick values that are not part of MathML Core. These were removed in Firefox 83 [1] but are still supported by WebKit [2].

Test results and supporting details

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1664488
[2] https://github.com/WebKit/WebKit/blob/0b0b865747d48a813eee3c2f52da026714bd61aa/Source/WebCore/mathml/MathMLFractionElement.cpp#L59

Related issues

N/A

@fred-wang
Update compat data for mfrac@linethickness
5f102b1 
This commit updates compat data for the linethickness attribute of the <mfrac> element:

- Replace notes about partial implementation in Safari with the use of
  of array of implementations.
- Use "mirror" for Safari iOS, its MathML implementation matches the
  macOS one.
- Add a subfeature for deprecated named values thin, medium, thick
  values that are not part of MathML Core. These were removed in
  Firefox 83 [1] but are still supported by WebKit [2].

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1664488
[2] https://github.com/WebKit/WebKit/blob/0b0b865747d48a813eee3c2f52da026714bd61aa/Source/WebCore/mathml/MathMLFractionElement.cpp#L59
@fred-wang
Copy link
Contributor Author

cc @Elchi3

@github-actions github-actions bot added the data:mathml ➗ Compat data for MathML features. https://developer.mozilla.org/docs/Web/MathML label Sep 30, 2022
Elchi3
Elchi3 requested changes Sep 30, 2022
View reviewed changes
mathml/elements/mfrac.json Show resolved Hide resolved
Elchi3
Elchi3 approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@Elchi3 Elchi3 merged commit 3212ee3 into mdn:main Sep 30, 2022
@fred-wang fred-wang deleted the mfrac-linethickness branch September 30, 2022 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
data:mathml ➗ Compat data for MathML features. https://developer.mozilla.org/docs/Web/MathML
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fred-wang @Elchi3