Add subfeature for deprecated named values of the mathsize attribute #17921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add subfeature for deprecated named values "small", "normal", "big" of the mathsize attribute. These were removed in Firefox 83 [1] but are still supported by WebKit [2]. [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1664488 [2] https://github.com/WebKit/WebKit/blob/cd711e64b46522100059a32e3025f7875e4861c0/Source/WebCore/mathml/MathMLElement.cpp#L117
github-actions
bot
added
the
data:mathml ➗
|
cc @Elchi3 |
Elchi3
requested changes
Sep 30, 2022
Co-authored-by: Florian Scholz <fs@florianscholz.com>
This reverts commit e625c88.
Elchi3
approved these changes
Sep 30, 2022
|
@Elchi3 no worries. thanks for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add subfeature for deprecated named values "small", "normal", "big" of the mathsize attribute. These were removed in Firefox 83 [1] but are still supported by WebKit [2]. Also use "mirror" for Safari iOS, it has the same MathML support as macOS.
Test results and supporting details
[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1664488
[2] https://github.com/WebKit/WebKit/blob/cd711e64b46522100059a32e3025f7875e4861c0/Source/WebCore/mathml/MathMLElement.cpp#L117
Related issues
N/A