Update compat data for the mpadded element #17953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- State that Chrome and Safari fully supports mpadded attributes as defined in MathML Core and remove old notes for partial implementation. - Also remove old note about a bug in Firefox too that is not super important. - Add subfeatures to describe non-standard features from legacy MathML implementations and indicate support for Safari and Firefox (see below). - Add missibg subfeature for the depth attribute. As explained on MDN [1], MathML Core accepts `<length-percentage>` for mpadded attributes but some browsers also support more values. More precisely: - Chrome parses them as `<length-percentage>` [2] - WebKit parses them as a legacy MathML length [3] [4] - Firefox parses them witht the complete legacy syntax [5] [6] [1] https://developer.mozilla.org/en-US/docs/Web/MathML/Element/mpadded [2] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/mathml/mathml_padded_element.cc;l=15;drc=047c7dc4ee1ce908d7fea38ca063fa2f80f92c77 [3] https://searchfox.org/wubkat/rev/e8e9be7353991aee7df45aa62f0e0148f16e6f9f/Source/WebCore/mathml/MathMLPaddedElement.cpp#51 [4] https://developer.mozilla.org/en-US/docs/Web/MathML/Attribute/Values#legacy_mathml_lengths [5] https://searchfox.org/mozilla-central/rev/d416a7b827c2d76b12848e355a4e03dde49ece25/layout/mathml/nsMathMLmpaddedFrame.cpp#117 [6] https://developer.mozilla.org/en-US/docs/Web/MathML/Element/mpadded#legacy_syntax
|
cc @Elchi3 |
github-actions
bot
added
the
data:mathml ➗
Elchi3
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test results and supporting details
As explained on MDN [1], MathML Core accepts
<length-percentage>for mpadded attributes but some browsers also support more values. More precisely:<length-percentage>[2][1] https://developer.mozilla.org/en-US/docs/Web/MathML/Element/mpadded
[2] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/mathml/mathml_padded_element.cc;l=15;drc=047c7dc4ee1ce908d7fea38ca063fa2f80f92c77
[3] https://searchfox.org/wubkat/rev/e8e9be7353991aee7df45aa62f0e0148f16e6f9f/Source/WebCore/mathml/MathMLPaddedElement.cpp#51
[4] https://developer.mozilla.org/en-US/docs/Web/MathML/Attribute/Values#legacy_mathml_lengths
[5] https://searchfox.org/mozilla-central/rev/d416a7b827c2d76b12848e355a4e03dde49ece25/layout/mathml/nsMathMLmpaddedFrame.cpp#117
[6] https://developer.mozilla.org/en-US/docs/Web/MathML/Element/mpadded#legacy_syntax
Related issues
mdn/content#21258